ocp cosesign decode/verify #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b9b46d.
parvathib
reviewed
Jan 6, 2026
parvathib
reviewed
Jan 8, 2026
swenson
reviewed
Jan 9, 2026
Collaborator
swenson
left a comment
swenson
left a comment
There was a problem hiding this comment.
I'm okay with merging this but we should maybe try to clean up the workspace in a follow-up if so.
swenson
approved these changes
Jan 12, 2026
fdamato
reviewed
Jan 13, 2026
Comment on lines
+6
to
+11
| use openssl::{ | ||
| bn::{BigNum, BigNumContext}, | ||
| ec::{EcGroup, EcKey, EcPoint}, | ||
| nid::Nid, | ||
| pkey::PKey, | ||
| x509::X509, |
Contributor
There was a problem hiding this comment.
perhaps in a different PR we can abstract crypto interface
Collaborator
There was a problem hiding this comment.
agree! we'll abstract the crypto interface in the upcoming PRs.
| )) | ||
| } | ||
|
|
||
| /// Extract raw P-384 public key coordinates (x, y) from DER X.509 cert |
Contributor
There was a problem hiding this comment.
consider to make this generic... we`re going to have MLDSA profile too, as soon as it will get ratified
Collaborator
There was a problem hiding this comment.
Agreed—we’ll generalize how the verification key is extracted in future PRs.
added 2 commits
January 13, 2026 16:12
… into meilu/ocp_cosesign_verify_clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocp cosesign decode/verify